Add Initial Speakers Endpoint #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor update to the existing code for the session list. The only real change is that the "id" is now the slug of the Talk and the "url" uses the talks slug instead of the pk. Further improvements will be made to the serializer, once the other endpoints/serializers are done.
The endpoint outputs basic information about speakers, including an endpoint for speaker details. At the moment there is no relationship to other entities yet. This will be added at a later point in time, like for example the talks the speaker has given or will give or the events the speaker presented at.
Pull Request Test Coverage Report for Build 1487266680
💛 - Coveralls |
|
@jandd Once we finalised business logic issues I'll be writing unit tests. So lets figure out how the initial endpoint should look like and be serialised first. |
jandd
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is stacked on top of #272
The endpoint outputs basic information about speakers, including an
endpoint for speaker details. At the moment there is no relationship to
other entities yet. This will be added at a later point in time, like
for example the talks the speaker has given or will give or the events
the speaker presented at.
I have changed the serialisation of the
imagefield to show an empty string instead ofnull.Example output of
/api/speakers:[ { "id": "ingo-albrecht", "url": "http://localhost:8000/api/speakers/ingo-albrecht/", "name": "Ingo Albrecht", "short_biography": "My short bio", "position": "", "image": "" }, { "id": "alexander-richter", "url": "http://localhost:8000/api/speakers/alexander-richter/", "name": "Alexander Richter", "short_biography": "My short bio", "position": "", "image": "http://localhost:8000/media/speaker_public/0c4aeb7a06d7f7e33587b997c509a0d73faa1cb3dc04ec56a6698725_thumbnail.png" } ]